Problems running a routine to compile a single job

CharlesNagy · Post by **CharlesNagy** » Wed Nov 28, 2007 7:21 am

I have been tasked with writing a routine which can be called from a master Job Control which runs a list of specified jobs. We have opted not to use sequencer jobs because our job scheduling requirements are somewhat complicated. My routine tries to attach a job, and if it won't attach it assumes it is uncompiled and tries to compile it.

The routine works. If you look at the Director afterwards, it shows that the Job is compiled, and if you then try to run it, it runs, no problem. However, if the job is run from job control, whilst it completes with no errors, the job control which runs it falls over with:

Job control process (pid 13976) has failed

That is the only error I get. The routine is posted below, the only argument passed is Job Name

I pinched the job compile logic from a routine I found called "CompileAllJobs" which does in fact work, but I suspect that when run under Job Control, it must leave the job in some indeterminate status, which therefore causes the process to abort.

Would appreciate any comments or ideas about the below code.

Code: Select all

********************************************************************************
** This routine tries to compile the job specified                            **
** If unsuccessful, will report on it                                         **
********************************************************************************

$INCLUDE DSINCLUDE JOBCONTROL.H
$INCLUDE DSINCLUDE DSR_UVCONST.H
$INCLUDE DSINCLUDE DSR_COMCONST.H

      RoutineName = "CheckJobCompile"

      Equate LOG.WARN.NAME To RoutineName
      Equate LOG.OK.NAME   To RoutineName

      JobsCompiled = ""
      CompileStatus = 0

* Get the current job's name and number:

      MyJobNo = JobName
      SUBR = DSR.SUB.JOB
      Key = DSR.SUB.JOB.GETNO
      Call @SUBR(Key, MyJobNo)
      Dummy1 = "" ; Dummy2 = ""

      SUBR = DSR.SUB.JOB
      Key = DSR.SUB.JOB.RESERVE

      Arg2 = JobName
      Call @SUBR(Key, Arg2)
      Call DSD.Init(MyJobNo, Dummy2)
      If Key <> "" Then
         WarnMsg = DSRMessage("", "Cannot attach to job '%1'", JobName):@FM:Key
         Call DSLogWarn(Lower(WarnMsg),LOG.WARN.NAME)
         CompileStatus = 0               ; * Unsuccessful compile
      End

      * try to compile it:
      Key = DSR.SUB.JOB.COMPILE
      Arg2 = JobName
      Call @SUBR(Key, Arg2)
      Call DSD.Init(MyJobNo, Dummy2)
      If Key <> "" Or Arg2<1> <> "" Then
         WarnMsg = DSRMessage("", "Problems compiling job '%1'", JobName):@FM:Key:@FM:Arg2
         Call DSLogWarn(Lower(WarnMsg), LOG.WARN.NAME)
         CompileStatus = 0               ; * unsuccessful compile
      End Else
         JobsCompiled<-1> = JobName
         CompileStatus = 1               ; * successful compile
         Call DSLogInfo("Job ":JobName:" Successfully Compiled", LOG.OK.NAME)
         * Clear the RT_STATUS and RT_LOG files
         Ignore = 0
         JobNo = DSRGetJob(JobName,Ignore)
         Execute "CLEAR.FILE ":DSR.RTSTATUS.FNAME:JobNo
         Execute "CLEAR.FILE ":DSR.RTLOG.FNAME:JobNo
      End

      Key = DSR.SUB.JOB.RELEASE          ; * unlock job, ignoring any errors
      Arg2 = JobName
      Call @SUBR(Key, Arg2)
      Call DSD.Init(MyJobNo, Dummy2)

      Ans = CompileStatus

chulett · Post by **chulett** » Wed Nov 28, 2007 7:49 am

CharlesNagy wrote:(Sorry if the code is not indented, indents seem to have been stripped out in the posting process)

That's what the Code tags are for.

Code: Select all

********** Begin ******************

********************************************************************************
** This routine tries to compile the job specified                            **
** If unsuccessful, will report on it                                         **
**
**                                                                            **
********************************************************************************

$INCLUDE DSINCLUDE JOBCONTROL.H
$INCLUDE DSINCLUDE DSR_UVCONST.H
$INCLUDE DSINCLUDE DSR_COMCONST.H

      RoutineName = "CheckJobCompile"

      Equate LOG.WARN.NAME To RoutineName
      Equate LOG.OK.NAME   To RoutineName

      JobsCompiled = ""
      CompileStatus = 0

* Get the current job's name and number:

      MyJobNo = JobName
      SUBR = DSR.SUB.JOB
      Key = DSR.SUB.JOB.GETNO
      Call @SUBR(Key, MyJobNo)
      Dummy1 = "" ; Dummy2 = ""

      SUBR = DSR.SUB.JOB
      Key = DSR.SUB.JOB.RESERVE

      Arg2 = JobName
      Call @SUBR(Key, Arg2)
      Call DSD.Init(MyJobNo, Dummy2)
      If Key <> "" Then
         WarnMsg = DSRMessage("", "Cannot attach to job '%1'", JobName):@FM:Key
         Call DSLogWarn(Lower(WarnMsg),LOG.WARN.NAME)
         CompileStatus = 0               ; * Unsuccessful compile
      End

      * try to compile it:
      Key = DSR.SUB.JOB.COMPILE
      Arg2 = JobName
      Call @SUBR(Key, Arg2)
      Call DSD.Init(MyJobNo, Dummy2)
      If Key <> "" Or Arg2<1> <> "" Then
         WarnMsg = DSRMessage("", "Problems compiling job '%1'", JobName):@FM:Key:@FM:Arg2
         Call DSLogWarn(Lower(WarnMsg), LOG.WARN.NAME)
         CompileStatus = 0               ; * unsuccessful compile
      End Else
         JobsCompiled<-1> = JobName
         CompileStatus = 1               ; * successful compile
         Call DSLogInfo("Job ":JobName:" Successfully Compiled", LOG.OK.NAME)
         * Clear the RT_STATUS and RT_LOG files
         Ignore = 0
         JobNo = DSRGetJob(JobName,Ignore)
         Execute "CLEAR.FILE ":DSR.RTSTATUS.FNAME:JobNo
         Execute "CLEAR.FILE ":DSR.RTLOG.FNAME:JobNo
      End

      Key = DSR.SUB.JOB.RELEASE          ; * unlock job, ignoring any errors
      Arg2 = JobName
      Call @SUBR(Key, Arg2)
      Call DSD.Init(MyJobNo, Dummy2)

      Ans = CompileStatus

****************** End *********

CharlesNagy · Post by **CharlesNagy** » Wed Nov 28, 2007 7:54 am

chulett wrote:
CharlesNagy wrote:(Sorry if the code is not indented, indents seem to have been stripped out in the posting process)

That's what the Code tags are for.

Yup, just tried to repost with code tags, you were too quick for me...

chulett · Post by **chulett** » Wed Nov 28, 2007 8:01 am

This was actually 'pinched' from Kenneth Bland's KBA Job Control Utilities, comments and all. It even still includes the structures it needs to process an array of job names at a time or that are part of his job control.

Looks to me like you've got your CompileStatus values bass-ackwards. Zero would be considered success while a non-zero value (1, in your case) would indicate failure. I'm assuming that is what is tripping up your job control code.

CharlesNagy · Post by **CharlesNagy** » Wed Nov 28, 2007 8:48 am

chulett wrote:This was actually 'pinched' from Kenneth Bland's KBA Job Control Utilities, comments and all. It even still includes the structures it needs to process an array of job names at a time or that are part of his job control.

Looks to me like you've got your CompileStatus values bass-ackwards. Zero would be considered success while a non-zero value (1, in your case) would indicate failure. I'm assuming that is what is tripping up your job control code.

Thanks Craig,

I didn't realise this was one of Ken Bland's routines, otherwise I would have given him credit. I just happened to find it on the server under "Utilities".

The CompileStatus flag is my own addition, which is just returned by my version of the routine so that I know wether the job compiled or not. Looking at the original code, it seemes to be around the right way... Whatever, after my routine is run, the Job Control attches the Job and runs it with no errors, it only falls over when it returns to Job control after running the job.....

kcbland · Post by **kcbland** » Wed Nov 28, 2007 9:28 am

Yeah, it's from my stuff, but then again, my stuff is a conglomeration of 10 years worth of other peoples stuff.

If the compile works, and the function call returns successfully, I don't know what's going wrong with the calling process. If it fails, that means the code aborted. My guess is that your logic here is fine, your problem is in the calling code.

kcbland · Post by **kcbland** » Wed Nov 28, 2007 9:35 am

I think found your problem! Remove these lines.

Execute "CLEAR.FILE ":DSR.RTSTATUS.FNAME:JobNo
Execute "CLEAR.FILE ":DSR.RTLOG.FNAME:JobNo

My mass-compiler has this logic, but if you're using this logic as part of job control you can get into trouble whiping out the status information of a job if you're attached to it or have many instances you're currently running. See if this makes a difference.

CharlesNagy · Post by **CharlesNagy** » Wed Nov 28, 2007 9:58 am

kcbland wrote:I think found your problem! Remove these lines.

Execute "CLEAR.FILE ":DSR.RTSTATUS.FNAME:JobNo
Execute "CLEAR.FILE ":DSR.RTLOG.FNAME:JobNo

My mass-compiler has this logic, but if you're using this logic as part of job control you can get into trouble whiping out the status information of a job if you're attached to it or have many instances you're currently running. See if this makes a difference.

Thanks Ken!

Will give it a go...

CharlesNagy · Post by **CharlesNagy** » Wed Nov 28, 2007 10:14 am

kcbland wrote:I think found your problem! Remove these lines.

Execute "CLEAR.FILE ":DSR.RTSTATUS.FNAME:JobNo
Execute "CLEAR.FILE ":DSR.RTLOG.FNAME:JobNo

My mass-compiler has this logic, but if you're using this logic as part of job control you can get into trouble whiping out the status information of a job if you're attached to it or have many instances you're currently running. See if this makes a difference.

Nope.... Still got the problem, but your suggestion has given me a couple of ideas. Perhaps the code is losing track of which job number it is on.... I will investigate further....

Thanks

CharlesNagy · Post by **CharlesNagy** » Mon Dec 03, 2007 4:56 am

CharlesNagy wrote:
kcbland wrote:I think found your problem! Remove these lines.

Execute "CLEAR.FILE ":DSR.RTSTATUS.FNAME:JobNo
Execute "CLEAR.FILE ":DSR.RTLOG.FNAME:JobNo

My mass-compiler has this logic, but if you're using this logic as part of job control you can get into trouble whiping out the status information of a job if you're attached to it or have many instances you're currently running. See if this makes a difference.
Nope.... Still got the problem, but your suggestion has given me a couple of ideas. Perhaps the code is losing track of which job number it is on.... I will investigate further....

Thanks

Further to my last post, I can't seem to resolve this any way I try. I removed the lines suggested by Ken but no luck. I ran the whole thing through as a function in test mode, and it works fine. (I put DslogInfo comments throughout). As soon as I try to run it from a job however, as soon as it hits the first call to DSD.Init, it craps out with the original error. The job gets compiled fine, but no other info messages are forthcoming.

I even tried creating a stand alone routine, compiling and cataloging it from the command line, and running it via an execute from within the job, so it wouldn't know it was being run from a job. Still no joy....

I suspect that a variable in common may be the culprit, but not having access to the code for DSD.Init, I have no clue as to which it could be.

I will probably implement a version of the CompileAll routine, and run it before I run the scheduler, to get around the problem. Thanks to everyone for their thoughts...

ray.wurlod · Post by **ray.wurlod** » Mon Dec 03, 2007 5:19 am

Is it even valid to call DSD.Init after DSR.SUB.JOB.RELEASE ?

CharlesNagy · Post by **CharlesNagy** » Tue Dec 04, 2007 2:25 am

ray.wurlod wrote:Is it even valid to call DSD.Init after DSR.SUB.JOB.RELEASE ?

It is my understanding that DSR.SUB.JOB.RELEASE is the argument that DSD.Init is called with. Anyhow, it was in the code I inherited. I don't pretend to understand what it does. I have tried to log on to Kens website to see if I can get his original code (but he hasn't approved me yet

), just in case the version I have has been "Imoroved".

Cheers and thanks

chulett · Post by **chulett** » Tue Dec 04, 2007 8:04 am

Hmmm... since the routine seems to work when run stand-alone and only has issues when launched from your job control, perhaps we should look there rather than focus on the routine itself? If you are willing to post the code which calls the routine, that is. And it might help explain what you meant by this:

after my routine is run, the Job Control attaches the Job and runs it with no errors, it only falls over when it returns to Job control after running the job.....

No quite clear exactly where/how this error manifests itself in the grand scheme of things.

kcbland · Post by **kcbland** » Tue Dec 04, 2007 9:40 am

Just FYI, the job control goodies on my site has the major job control function that features compilation of jobs at startup as well as prior to running a job. My point is that compiling a job is not your problem, it's the code calling the compiling routine. That's why I thought clearing the status file was interfering with your running the same job.

CharlesNagy · Post by **CharlesNagy** » Wed Dec 05, 2007 7:34 am

kcbland wrote:Just FYI, the job control goodies on my site has the major job control function that features compilation of jobs at startup as well as prior to running a job. My point is that compiling a job is not your problem, it's the code calling the compiling routine. That's why I thought clearing the status file was interfering with your running the same job.

Thanks Ken,

After you very kindly gave me access to your site, I was able to download the "Compile all jobs" code, and compare it with the code I had inherited. There was one slight difference, whether inadvertant or not.

The section right at the beginning of the code I was using says:

MyJobNo = JobName
SUBR = DSR.SUB.JOB
Key = DSR.SUB.JOB.GETNO
CALL @SUBR(Key, MyJobNo)

In your code it says:

MyJobNo = DSJobName

This makes all the difference. The routine now works when called from job control. (It always worked stand alone, ie in test mode)

I am going to mark this resolved now.

Thanks Ken!

DSXchange

Problems running a routine to compile a single job

Problems running a routine to compile a single job

Re: Problems running a routine to compile a single job

Re: Problems running a routine to compile a single job