Append date with file

chulett · Post by **chulett** » Tue Aug 15, 2006 8:48 pm

I know the issue you've got with the macro, we've discussed it quite a bit in recent days so knew the dashes would be an issue.

It's hard for me to know your silly mistake when I can't see your job. What you should be able to do to make it work is have a job parameter with the full path to the file to create - the one without the date. It looks like you've called that FILE, so both the Sequential File stage and the After Job subroutine should use #FILE#. The routine will take the file and rename it with the current date formatted properly I assume. None of this silly #testsubroutine# stuff.

The other trick here is the filename cannot include the extension for the rename to work correctly. If you are comfortable doing this, drop it from the parameter value and hard-code the ".txt" extension in the Sequential File stage, much like it is hard-coded in the posted routine.

I believe you'll need to modify the routine to pull the filename from the path to it. From what I recall, the DOS rename command wants the full path to the original file, but only the new filename on the other side. For example:

Code: Select all

ren /a/b/c/test.txt test_08152006.txt

Check the help for the command to confirm.

urshit_1983 · Post by **urshit_1983** » Tue Aug 15, 2006 9:04 pm

Thank you so much. Hope i should be able to get it now.

Thank you everybody for your time.

kris007 · Post by **kris007** » Tue Aug 15, 2006 9:49 pm

chulett wrote:
I believe you'll need to modify the routine to pull the filename from the path to it. From what I recall, the DOS rename command wants the full path to the original file, but only the new filename on the other side.

And thats exactly what the routine from DSGuru was expecting as Arg1.

urshit_1983 · Post by **urshit_1983** » Wed Aug 16, 2006 7:56 am

Ok I have tried but its creating the file with name :

test.txt

No renaming is done and no date is appended to file name.

Is the subroutine given by DSGuru good. Can someone check it please ?

Thnx

kris007 · Post by **kris007** » Wed Aug 16, 2006 8:58 am

The routine looks good to me. Have you tried it testing seperately from Manager? What happens when you do that? I would suggest you test it from Manager and make sure that the routine is working as per your requirement(else make some changes) and then try using it in the after job subroutine.

urshit_1983 · Post by **urshit_1983** » Wed Aug 16, 2006 9:09 am

Yes kris I have tried in Manager but I can only compile and not Test. Dont know why...

May be becoz of the RETURN ??
Because in last line of subroutine posted its Ans=.......
And in bottom tab of routine dialog box its just RETURN.

So may be its not returning the value properly....

prabu · Post by **prabu** » Wed Aug 16, 2006 9:18 am

please try the following code. i believe ren is not a valid DOS command , but mv works. All the best!!

Code: Select all

* courtesy DSGuru
* The intention of this site it to give you a fishing rod, worm 
* and fishing boat, somtimes
* it cannot cook the fish remotely  :lol:  :lol: 
FileName = Arg1
CurrDate = Oconv(Date(), "DMDY[2,2,4]": @VM : "MCN")
NewFileName = FileName:"_":CurrDate:".txt" 
DosCommand = "mv ":FileName NewFileName
Call DSExecute ("DOS",DosCommand,Output,SystemReturnCode) 

Ans = SystemReturnCode

chulett · Post by **chulett** » Wed Aug 16, 2006 9:25 am

'ren' is short for rename and is a perfectly valid DOS command, it's 'mv' that isn't. 'mv' is a UNIX command and will work for you only if you have something like the MKS Toolkit installed.

The routine is not quite right, as I noted in my post. It needs to be tweaked to support the syntax as required by the rename command.

kris007 · Post by **kris007** » Wed Aug 16, 2006 9:49 am

I have made a small change to the routine. I have included the filepath as the parameter where filepath is the dir the file resides. Now, try testing this routine.

Code: Select all

FileName = Arg1 
FilePath =Arg2
CurrDate = Oconv(Date(), "DMDY[2,2,4]": @VM : "MCN") 
NewFileName = FileName:"_":CurrDate:".txt" 
DosCommand = "ren ":FilePath:'\':FileName NewFileName 
Call DSExecute ("DOS",DosCommand,Output,SystemReturnCode) 

Ans = SystemReturnCode

FileName = Name of the file.
FilePath = Path of the file.

And what do you mean by saying that you can only compile and not test? You are not able to test means the routine has not compiled successfully. If you were able to compile the routine without any errors and warnings, then you should be able to test it.

urshit_1983 wrote:Because in last line of subroutine posted its Ans=.......

The last line says Ans = SystemReturnCode.

urshit_1983 · Post by **urshit_1983** » Wed Aug 16, 2006 10:07 am

Ahaaa. I got my BIGGEST MISTAKE. I didnt notice by mistake, I have posted OS-Windows in my question. But its Unix. Moreover stupid enough that I am using DOS command in the subroutine.

Extremely Sorry guys. So what modifications needed now ??

kris007 · Post by **kris007** » Wed Aug 16, 2006 10:15 am

Code: Select all

FileName = Arg1 
FilePath =Arg2 
CurrDate = Oconv(Date(), "DMDY[2,2,4]": @VM : "MCN") 
NewFileName = FileName:"_":CurrDate:".txt" 
UnixCommand = "mv ":FilePath:'/':FileName NewFileName 
Call DSExecute ("UNIX",UnixCommand,Output,SystemReturnCode) 

Ans = SystemReturnCode

urshit_1983 · Post by **urshit_1983** » Wed Aug 16, 2006 10:34 am

When I am compiling it say : Compiled with no errors
But then the Test button does not get bold. So I cannot click and test it.

Moreover I tried to build a transform routine which worked fine with this code :

FileName = Arg1
FilePath =Arg2
CurrDate = Oconv(Date(), "DMDY[2,2,4]": @VM : "MCN")
NewFileName = FileName:"_":CurrDate:".txt"
Ans = NewFileName

urshit_1983 · Post by **urshit_1983** » Wed Aug 16, 2006 10:34 am

When I am compiling it say : Compiled with no errors
But then the Test button does not get bold. So I cannot click and test it.

Moreover I tried to build a transform routine which worked fine with this code :

FileName = Arg1
FilePath =Arg2
CurrDate = Oconv(Date(), "DMDY[2,2,4]": @VM : "MCN")
NewFileName = FileName:"_":CurrDate:".txt"
Ans = NewFileName

kris007 · Post by **kris007** » Wed Aug 16, 2006 10:58 am

Two things you could do:

1. Create the routine with the code provided earlier as a Before/After subroutine and execute it in your Job and see if its working.

2. Create the routine with the code provided earlier as a Transform Function and test it in the Manager and then use it as Before/After Routine.

Note: Create the Routine in the Before/After Directory in order for it to appear in the Before/After Subroutine in Job Properties window.

I don't think the code you provided solves your purpose as it is just creating a file with a new name. I don't think it's copying the contents of the old file into the new file.

DSguru2B · Post by **DSguru2B** » Wed Aug 16, 2006 1:19 pm

Wow, this topic is still alive. And after all this time you tell us its unix. Well, it happens

If its unix then you dont even need a routine. Just append the date to the file by running afterjob subroutine 'Execsh'

Code: Select all

mv yourfile.txt yourfile_`date +"%Y%m%d"`.txt